[FFmpeg-devel] a64 encoder 7th round

[Michael Niedermayer]

On Mon, Jan 26, 2009 at 08:33:05AM +0100, Bitbreaker/METALVOTZE wrote:
[...]

>>> +    CODEC_ID_A64_MULTI,
>>> +    CODEC_ID_A64_MULTI5,
>> What differnce is there between the 2 codecs?
>> Either way i dont think it justifies 2 coedec ids.
>
> The difference is not really big. The normal multicol mode works with a 
> fixed color in the colram, thus having a range of 4 colors (3 multicol 
> registers + colorram). That covers a luminance range from black up to light 
> gray.
> The 5col mode extends the dynamic range, by displaying the brightest and 
> the darkest color with the color defined by the colorram. That means i need 
> to add the colorram for each frame and therefore i am able to display a 
> range from black to white (however black and white may not occur at once in 
> a 8x8 block, else i scale either white down or black up if that happens).
> I have chosen the way of two codecs, as i lacked an appropriate option to 
> set it. As for the charset lifetime i now use qscale, maybe there is also a 
> commandline option that suites that behaviour well? Then i can of course 
> just use a single codec ID.

is there any reason not to use 5col mode?


[...]

> +AVCodec a64multi_encoder = {
> +    .name = "a64multi",
> +    .type = CODEC_TYPE_VIDEO,
> +    .id = CODEC_ID_A64_MULTI,
> +    .priv_data_size = sizeof(A64Context),
> +    .init = a64multi_init_encoder,
> +    .encode = a64multi_encode_frame,
> +    .close = a64multi_close_encoder,
> +    .pix_fmts = (enum PixelFormat[]) {PIX_FMT_GRAY8, PIX_FMT_NONE},
> +    .long_name = NULL_IF_CONFIG_SMALL("Multicolor charset for Commodore 64"),
> +    .capabilities = CODEC_CAP_DELAY,
> +};

can be vertically aligned so = is at the same spot


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090126/40f2fa92/attachment.pgp>