[FFmpeg-devel] [RFC] use AV_WL32/AV_WB32 in put_bits

Michael Niedermayer michaelni
Sun Jan 25 18:54:49 CET 2009


On Sun, Jan 25, 2009 at 11:49:15AM +0100, Reimar D?ffinger wrote:
> Hello,
> I do not know if this was maybe intentional, but it seems to me put_bits

i think the code predates AV_WL32() and likely was just missed
so patch ok

> could use those macros to at least simplify the code, possibly to even
> speed it up.
> Maybe it could be simplified even more, since the else part is the same
> as AV_W?32, too, when HAVE_FAST_UNALIGNED is set.

yes indeed, the whole if/else could be replaced by a single AV_W...
this should be benchmarked though

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090125/e9159578/attachment.pgp>



More information about the ffmpeg-devel mailing list