[FFmpeg-devel] [PATCH] Fix for broken build

Reimar Döffinger Reimar.Doeffinger
Sun Jan 25 10:13:43 CET 2009


On Sun, Jan 25, 2009 at 12:46:20AM +0000, M?ns Rullg?rd wrote:
> >> Agreed.  So that leaves two proposed solutions:
> >> 1) the patch I added which removes the unneeded include of config.h in mem.h
> >
> > For this to be acceptable you also need to remove the following code:
> >
> > #elif HAVE_INLINE_ASM
> >     #error The asm code needs alignment, ...
> >
> > because that's what actually require config.h.
> 
> The warning can be squashed by changing the line to
> 
> #if defined(HAVE_INLINE_ASM) && HAVE_INLINE_ASM
> 
> That's still not addressing the real issue though.

IMO get rid of the config.h include (and use the one included by
common.h) and put anything that needs config.h under
#ifdef HAVE_AV_CONFIG_H
Unless you think those macros should be moved to some non-installed
header, e.g. internal.h

Greetings,
Reimar D?ffinger




More information about the ffmpeg-devel mailing list