[FFmpeg-devel] [PATCH] Fix for broken build

Art Clarke aclarke
Sat Jan 24 23:09:48 CET 2009

On Sat, Jan 24, 2009 at 2:04 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> Hi,
> On Sat, Jan 24, 2009 at 4:50 PM, Art Clarke <aclarke at xuggle.com> wrote:
>> On Sat, Jan 24, 2009 at 11:39 AM, Art Clarke <aclarke at xuggle.com> wrote:
>>> 2) change the configure script to install config.h by default (a bad
>>> idea I think, but I'm not sure).
>> and no I know why a bad idea; because other (admittedly stupid)
>> programs might install a /usr/local/config.h and either override
>> libav's, or ffmpeg would override someone elses.
> It's also a packaging problem. The build and install/run host might
> not be the same, and thus their config.h might (have to) differ.

Agreed.  So that leaves two proposed solutions:
1) the patch I added which removes the unneeded include of config.h in mem.h
2) tell libav users they can't include mem.h, and hence cannot use
av_malloc or av_free

As you might guess, I strongly vote for #1.

- Art

More information about the ffmpeg-devel mailing list