[FFmpeg-devel] dia, dia_size and the rest

[Michael Niedermayer]

On Fri, Jan 23, 2009 at 08:44:01PM +0000, Robert Swain wrote:
> 2009/1/23 Michael Niedermayer <michaelni at gmx.at>:
> > On Fri, Jan 23, 2009 at 05:34:49PM +0000, Robert Swain wrote:
> >> 2009/1/23 Michael Niedermayer <michaelni at gmx.at>:
> >> > On Fri, Jan 23, 2009 at 03:47:44PM +0000, vmrsss wrote:
> >> >> I have tried to use me_method hex with mpeg2video and got:
> >> >>
> >> >> > [mpeg2video @ 0x101005800]me_method is only allowed to be set to
> >> >> > zero and epzs; for hex,umh,full and others see dia_size
> >> >>
> >> >> I suppose there are precise rules on which video codecs support which
> >> >> motion estimation algorithms. What are they?
> >> >
> >> > the rule is above, what part of it is unclear?
> >> > Do you have some suggestion how to make it clearer?
> >> > The rule is not dependant on the used codec.
> >>
> >> I still think the patterns should not be controlled by the dia_size
> >> variable. It seems illogical to me. Control of the pattern/algorithm
> >> should be given to me_method and maybe dia_size should be me_size or
> >> something.
> >
> > patch welcome, but make sure it looses no speed
> 
> Why would it lose any speed? These are just config options aren't they?

because an additional variable would be accessed in the inner parts of the
code. But then i dont think this is relevant / meassureable ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090123/a64c7d89/attachment.pgp>