[FFmpeg-devel] [PATCH] ADTS AAC with ID3v2

[Michael Niedermayer]

On Fri, Jan 23, 2009 at 09:54:24AM -0800, David DeHaven wrote:
>
>>> +    if(ff_id3v2_match(bufptr))
>>> +        bptr += ff_id3v2_tag_len(bufptr);
>>>
>> how did you get the compiler past bptr?
>
> Gah! I did it again...
>
> Ok, this time I TRIPLE checked the attachment was the right one :)

what attachment ?

just kidding ;)


[...]
> Index: libavformat/raw.c
> ===================================================================
> --- libavformat/raw.c	(revision 16729)
> +++ libavformat/raw.c	(working copy)
> @@ -289,6 +289,19 @@
>      st->codec->codec_id = s->iformat->value;
>      st->need_parsing = AVSTREAM_PARSE_FULL;
>      /* the parameters will be extracted from the compressed bitstream */
> +    

trailing whitespace


> +    if(st->codec->codec_id == CODEC_ID_FLAC) {
> +        /* skip ID3v2 header if found */
> +        uint8_t buf[ID3v2_HEADER_SIZE];
> +        int ret = get_buffer(s->pb, buf, ID3v2_HEADER_SIZE);
> +        if ((ret == ID3v2_HEADER_SIZE) && ff_id3v2_match(buf)) {

superflous ()

but i think the patch is ok except these now :)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090123/c180a1b4/attachment.pgp>