[FFmpeg-devel] a64 encoder

Aurelien Jacobs aurel
Tue Jan 20 20:29:00 CET 2009


Bitbreaker/METALVOTZE wrote:

> > Just a few comments (only at a64multi.c, since I still believe it is 
> > better to do one encoder at a time)...
> 
> Reduced patch to multi now.
> 
> > It looks like this encoder really need GRAY8 input, so I think it is 
> > better to let ffmpeg do the conversion.
> 
> Switched to grayscale input.
> 
> > You are ignoring half of the lines of the input. You should at least 
> > average them.
> 
> Average is build now.
> 
> Also some further cosmetics were done and a few parts of the code were 
> simplified (squeezed out another ~20% speedup).
> 
> By that, you find attached the 4th iteration.
> 
> [...]
> 
> Index: libavcodec/a64enc.h
> ===================================================================
> --- libavcodec/a64enc.h	(Revision 0)
> +++ libavcodec/a64enc.h	(Revision 0)
> @@ -0,0 +1,48 @@
> +[...]
> +
> +#include "avcodec.h"
> +#include "libavutil/random.h"
> +
> +#ifndef AV_CODEC_A64ENC_H
> +#define AV_CODEC_A64ENC_H

Should be AVCODEC_ instead of AV_CODEC_, and the #include should be
after the #ifdef.

Aurel




More information about the ffmpeg-devel mailing list