[FFmpeg-devel] [PATCH] Copy width/height for subtitle streams in ffmpeg

[David Conrad]

On Jan 17, 2009, at 6:44 PM, Michael Niedermayer wrote:

> On Sat, Jan 17, 2009 at 12:22:06PM -0800, Baptiste Coudurier wrote:
>> Hi,
>>
>> David Conrad wrote:
>>> On Jan 11, 2009, at 4:44 AM, Michael Niedermayer wrote:
>>>
>>>> On Sun, Jan 11, 2009 at 02:12:31AM -0500, David Conrad wrote:
>>>>> Hi,
>>>>>
>>>>> This copies stream width/height for -scodec copy in ffmpeg,
>>>>> useful for mov/mp4 timed text and ignored for about every other
>>>>> subtitle codec.
>>>>>
>>>>> commit 60039bb8c900ef4562e9ea4d5f9b0de2bdfa713f Author: David
>>>>> Conrad <davedc at Kozue.local> Date:   Sun Jan 11 02:10:22 2009
>>>>> -0500
>>>>>
>>>>> Copy width/height for subtitle streams
>>>> what does width/height mean for these subtitles?
>>>
>>> Essentially, the same thing it would mean if you consider the
>>> subtitles a transparent video track overlaid on top of the normal
>>> video track.
>>>
>>> For example, if you have a video 320x240 and subs 320x120, the subs
>>> would be on the top half of the video even if the actual positioning
>>> of the subs is aligned with the bottom.
>>>
>>> Or if you had subs 320x320, the subs could be underneath the actual
>>> video.
>>
>> Would it be possible to apply this patch ? Indeed it is very useful  
>> to
>> be able to scopy subs track from m4v/mov to m4v/mov.
>
> Ive no objections to the patch, i just was not sure if w/h or  
> extradata
> was better way but considering i still dont know which is better lets
> apply the patch.

I think extradata would require more code and be potentially confusing  
given that we already put (part of) the stsd atom in there for  
mov_text, so applied.