[FFmpeg-devel] Broken compile with latest libavutil/common.h

[Aurelien Jacobs]

On Sat, 17 Jan 2009 03:06:06 +0100
Michael Niedermayer <michaelni at gmx.at> wrote:

> On Fri, Jan 16, 2009 at 12:53:24AM +0100, Aurelien Jacobs wrote:
> > Michael Niedermayer wrote:
> [...]
> > > [...]
> > > > 
> > > > > +/* math */
> > > > > +int64_t av_const ff_gcd(int64_t a, int64_t b);
> > > > 
> > > > The function is in mathematics.c.  Maybe mathematics.h would be a good
> > > > place for this prototype.  
> > > 
> > > > Maybe we should even make that function
> > > > public.
> > > 
> > > I think so too
> > 
> > Done in attached patch.
> 
> ok

Applied.

> > > > > +/**
> > > > > + * converts fourcc string to int
> > > > > + */
> > > > > +static inline av_pure int ff_get_fourcc(const char *s){
> > > > > +    assert( strlen(s)==4 );
> > > > > +    return (s[0]) + (s[1]<<8) + (s[2]<<16) + (s[3]<<24);
> > > > > +}
> > > > 
> > > > This looks a lot like AV_RL32().  
> > > 
> > > indeed and i wouldnt mind seeing all ff_get_fourcc replaced by it
> > 
> > See attached patch.
> 
> ok

Applied.

Now the only non-public part left in common.h is mid_pred().
Is moving it to libavcodec/internal.h OK ?
If not, where should it be moved ?

Aurel