[FFmpeg-devel] [PATCH] Funcom ISS playback

Stefan Gehrer stefan.gehrer
Fri Jan 16 23:33:02 CET 2009


Diego Biurrun wrote:
> On Fri, Jan 16, 2009 at 10:18:21PM +0100, Stefan Gehrer wrote:
>> I reworked Jai Menon's patch from last April to play back Funcom ISS
>> Audio files and I think I took care of all the comments made at the
>> time.
>>
>> --- libavformat/iss.c	(revision 0)
>> +++ libavformat/iss.c	(revision 0)
>> @@ -0,0 +1,126 @@
>> +
>> +char *get_token(ByteIOContext *s, char *buf, int maxlen) {
>> +
>> +static int iss_probe(AVProbeData *p)
>> +{
> 
> Please consistently use K&R function declarations.

By K&R function declarations you mean putting the opening brace
on a new line?
I will do so in a revised patch, and I also noticed that get_token
should be declared static.

Stefan




More information about the ffmpeg-devel mailing list