[FFmpeg-devel] [PATCH] RDFT for Bink audio

[Daniel Verkamp]

On Thu, Jan 15, 2009 at 12:49 AM, Alex Converse <alex.converse at gmail.com> wrote:
> Hi,
>
> Attached is an implementation of the Real Discrete Fourier Transform as
> required for Bink Audio.

Thanks!

Tested with Bink audio decoder on files using RDFT and it works fine.

Nitpicking:

+/**
Trailing whitespace

+    if (ff_fft_init(&s->fft, nbits-1, inverse>0) < 0)
The meaning of inverse could be changed to match the FFT (0 or 1) for
consistency's sake.  I didn't realize it was different when I wrote
the wrappers.

+/** Map one real FFT into two parallel real even and odd FFTs. Then interleaved
interleaved -> interleave

Other than that, looks good to me.

Thanks,
-- Daniel Verkamp