[FFmpeg-devel] [PATCH]VDPAU patch for MPEG1/2 decoding, round 5

[Reimar Döffinger]

On Sun, Jan 11, 2009 at 02:37:06PM +0100, Carl Eugen Hoyos wrote:
> Attached patch works for me if I use the following code in vd_ffmepg.c
> (and every working simplification or modification will also need to test 
> codec_id):
>
>         case IMGFMT_VDPAU_MPEG1:
>             if(avctx->pix_fmt==PIX_FMT_VDPAU_MPEG && 
> avctx->codec_id==CODEC_ID_MPEG1VIDEO) return CONTROL_TRUE;
>             break;
>         case IMGFMT_VDPAU_MPEG2:
>             if(avctx->pix_fmt==PIX_FMT_VDPAU_MPEG && 
> avctx->codec_id==CODEC_ID_MPEG2VIDEO) return CONTROL_TRUE;
>             break;

That all seems very wrong to me, firstly IMO libavcodec has no business
whatsoever to mess with codec_id _ever_, so this relies on a bug in
libavcodec..