[FFmpeg-devel] [PATCH] Add support for muxing timed text in mov/mp4/3gp

[David Conrad]

On Jan 11, 2009, at 4:32 AM, Baptiste Coudurier wrote:

> David Conrad wrote:
>>> [...]
>>>
>>> if (track->mode == MODE_IPOD) hdlr_type = "sbtl";
>>> else                          hdlr_type = "text";
>>
>> With closed captioning muxing (CEA-608), hdlr_type has to be clcp,  
>> but
>> we can worry about that later.
>>
>
> Interesting are you working on this too ?

Eventually, I want normal subs working easily on my iPod first :D

>>>> @@ -897,8 +949,12 @@ static int mov_write_minf_tag(ByteIOContext  
>>>> *pb,
>>>> MOVTrack *track)
>>>>    put_tag(pb, "minf");
>>>>    if(track->enc->codec_type == CODEC_TYPE_VIDEO)
>>>>        mov_write_vmhd_tag(pb);
>>>> -    else
>>>> +    else if (track->enc->codec_type == CODEC_TYPE_AUDIO)
>>>>        mov_write_smhd_tag(pb);
>>>> +    else if (track->mode == MODE_MOV)
>>>> +        mov_write_gmhd_tag(pb);
>>>> +    else
>>>> +        mov_write_nmhd_tag(pb);
>>>
>>> Missing codec_type == CODEC_TYPE_SUBTITLE
>>
>> In a sense, gmhd/nmhd aren't really specific to subtitles; gmhd at  
>> least
>> is used by QuickTime for a lot of different obscure track types.  
>> Still,
>> fixed since none of them are supported.
>
> Yes that's true, like 'tmcd' tracks.
>
> Patch looks ok.

Applied.