[FFmpeg-devel] NC camera patch

[Diego Biurrun]

On Fri, Jan 09, 2009 at 10:39:19PM -0500, nicolas martin wrote:
>
> The new patch is attached.
>
> --- libavformat/ncdec.c	(revision 0)
> +++ libavformat/ncdec.c	(revision 0)
> @@ -0,0 +1,88 @@
> +/*
> + * NC cameras feed demuxer.

camera, drop the period

> + * Copyright (c) 2008  Nicolas Martin <martinic at iro.umontreal.ca>, Edouard Auvinet

2009

> +static int nc_probe(AVProbeData *probe_packet)
> +{
> +    return (AV_RL32(probe_packet->buf)==NC_VIDEO_FLAG?AVPROBE_SCORE_MAX:0);

useless parentheses

> +    st->codec->codec_type = CODEC_TYPE_VIDEO;
> +    st->codec->codec_id = CODEC_ID_MPEG4;
> +    st->need_parsing = AVSTREAM_PARSE_FULL;

This could be aligned.

> +    pkt->pos = url_ftell(s->pb);
> +    pkt->stream_index = 0;

ditto

Diego