[FFmpeg-devel] [PATCH] RTSP-MS 4/15: blocksize detection

Michael Niedermayer michaelni
Thu Jan 8 03:29:12 CET 2009

On Wed, Jan 07, 2009 at 09:17:32PM -0500, Ronald S. Bultje wrote:
> Hi,
> On Wed, Jan 7, 2009 at 9:14 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > i prefer the patch that doesnt add blocksize to the struct :)
> Then I can't error out if the value is too large... I'd prefer to be
> able to do that (and do that).

why do you want to fail due to a unused variable?
there should be a check for the actual packet or whatever being to
Just IMHO of course ...

If you really wanted to fail for that passing a context for av_log into
the function might be an option but then its ugly and anyway iam not
maintainer so this is all not my decission anyway not to mention i
dont care too much as long as its not exploitable.


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090108/2481cb54/attachment.pgp>

More information about the ffmpeg-devel mailing list