[FFmpeg-devel] [PATCH] RTSP-MS 8/15: disallow UDP/RTSP-MS

[Ronald S. Bultje]

Hi Luca,

On Tue, Jan 6, 2009 at 7:47 AM, Luca Barbato <lu_zero at gentoo.org> wrote:
> W/out this patch you get an error, with this patch you get an error as
> well, is that necessary?

No error. The return 1; makes the calling code re-try with other
protocols (until TCP is tried). The user never notices anything unless
compiled with some of the debugging printf()s uncommented in rtsp.c.

In the previous code, the server returns 461 on the _second_ stream.
The first OK'es fine with a 200 reply. If you look carefully at the
code, only a 461 response on the first stream means a new attempt is
made with a different stream, otherwise it's interpreted as a fatal
error (maybe that should change, that would be an alternative solution
to this problem).

Regardless, adding an av_log() is a good idea, I'll do that.

Ronald