[FFmpeg-devel] [PATCH]VDPAU patch for MPEG1/2 decoding, round 1

[Reimar Döffinger]

On Mon, Jan 05, 2009 at 04:06:22PM +0000, Carl Eugen Hoyos wrote:
> > Also the IDCT should be set at the same place and in the same way as for
> > XVMC.
> 
> Wouldn't that complicate the patch?

I don't think so, but inconsistent behaviour seems worse to me than a
minimally more complex patch.
Currently with xvmc it is possible to force a different idct_algo
whereas with VDPAU that wouldn't be possible.
Probably it does not make sense for either one, still consistent
behaviour is preferable.

> > > Index: libavcodec/vdpau_render.h
> > > ===================================================================
> > > --- libavcodec/vdpau_render.h	(revision 16437)
> > > +++ libavcodec/vdpau_render.h	(working copy)
> > > @@ -70,6 +70,7 @@
> > >  
> > >      /** picture parameter information for all supported codecs */
> > >      union VdpPictureInfo {
> > > +        VdpPictureInfoMPEG1Or2 mpeg;
> > 
> > What is 10r2 supposed to mean?
> 
> It is how NVIDIA calls the Picture parameter information struct in the VDPAU
> header /usr/include/vdpau/vdpau.h

Well, it makes more sense after you realize it is an "O" and not a "0".
Not an example for a good name.