[FFmpeg-devel] [PATCH]Possible configure support for VDPAU

[Carl Eugen Hoyos]

Hi Diego!

Diego Biurrun <diego <at> biurrun.de> writes:

> > Attached patch implements configure (and shared library) support for  
> > VDPAU.
> > If the library is compiled on a system where no VDPAU headers are  
> > installed, it cannot use VDPAU. Still, this patch installs a (possibly  
> > useless) vdpau_render.h. Is this wanted?
> 
> I think yes, VDPAU headers/support could be installed later.
> 
> > configure does not die if --enable-vdpau was used, but the necessary  
> > headers are missing, but simply disables vdpau.
> 
> It behaves similarly in other cases.

Out of curiosity: For which ones?

> > +vdpau_deps="vdpau_vdpau_h vdpau_vdpau_x11_h"
> 
> Shouldn't this be h264_vdpau_decoder_deps?

No, because there will be two more _vdpau_decoder values that depend on vdpau.

> > @@ -1827,6 +1830,8 @@
> >  check_header sys/select.h
> >  check_header termios.h
> >  check_header X11/extensions/XvMClib.h
> > +check_header vdpau/vdpau.h
> > +check_header vdpau/vdpau_x11.h
> 
> This was in alphabetical order before.

Thank you, fixed locally.

> > -HEADERS = avcodec.h opt.h
> > +HEADERS = avcodec.h opt.h vdpau_render.h
> 
> I wonder if vdpau_render.h is a good name for the header.

If you suggest another name, I'll happily change it.

Thank you for your review, Carl Eugen