[FFmpeg-devel] [RFC] rtsp.c EOF support

[Michael Niedermayer]

On Sat, Feb 28, 2009 at 02:43:06PM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Sat, Feb 28, 2009 at 2:40 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Sat, Feb 28, 2009 at 02:36:06PM -0500, Ronald S. Bultje wrote:
> >> @@ -1328,10 +1328,10 @@
> >> ? ? ? ? ? ? ?if (rtsp_st->rtp_handle) {
> >> ? ? ? ? ? ? ? ? ?/* currently, we cannot probe RTCP handle because of
> >> ? ? ? ? ? ? ? ? ? * blocking restrictions */
> >> - ? ? ? ? ? ? ? ?rtp_get_file_handles(rtsp_st->rtp_handle, &fd1, &fd2);
> >> - ? ? ? ? ? ? ? ?if (fd1 > fd_max)
> >> - ? ? ? ? ? ? ? ? ? ?fd_max = fd1;
> >> - ? ? ? ? ? ? ? ?FD_SET(fd1, &rfds);
> >> + ? ? ? ? ? ? ? ?fd = url_get_file_handle(rtsp_st->rtp_handle);
> >> + ? ? ? ? ? ? ? ?if (fd > fd_max)
> >> + ? ? ? ? ? ? ? ? ? ?fd_max = fd;
> >> + ? ? ? ? ? ? ? ?FD_SET(fd, &rfds);
> >
> > you did expect me to accept a variable renaming in a functional patch?
> 
> Well, the old ones are called fd1 and fd2 and one of them becomes
> obsolete, so keeping fd1 seemed kind of illogical. Anyway, if you so
> wish, I'll keep fd1 and rename it to fd in a separate patch after
> this. Other than that, is the rest ok?

ill review it after the release when i have time or you can post a
clean patch now then ill try to review it now.
sorry but i have much more work to do then there is time and iam
not willing to spend extra time seperating cosmetic changes out of
your patches to review the rest.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090228/68cd8c10/attachment.pgp>