[FFmpeg-devel] [RFC] rtsp.c EOF support

[Michael Niedermayer]

On Sat, Feb 28, 2009 at 02:36:06PM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Sat, Feb 28, 2009 at 2:33 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Sat, Feb 28, 2009 at 02:25:49PM -0500, Ronald S. Bultje wrote:
> >> On Sat, Feb 28, 2009 at 1:51 PM, M?ns Rullg?rd <mans at mansr.com> wrote:
> >> > Converting from int to pointer and back should be safe on all systems
> >> > we care about.
> >>
> >> Aha, then the attached patch might just make sense.
> >
> > probably ok
> 
> Then attached is an updated implementation of url_get_file_handle().
[...]
> @@ -1328,10 +1328,10 @@
>              if (rtsp_st->rtp_handle) {
>                  /* currently, we cannot probe RTCP handle because of
>                   * blocking restrictions */
> -                rtp_get_file_handles(rtsp_st->rtp_handle, &fd1, &fd2);
> -                if (fd1 > fd_max)
> -                    fd_max = fd1;
> -                FD_SET(fd1, &rfds);
> +                fd = url_get_file_handle(rtsp_st->rtp_handle);
> +                if (fd > fd_max)
> +                    fd_max = fd;
> +                FD_SET(fd, &rfds);

you did expect me to accept a variable renaming in a functional patch?


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090228/31ab7378/attachment.pgp>