[FFmpeg-devel] [PATCH] rtpdec.c: don't overwrite pkt->stream_index in finalize_packet()

[Ronald S. Bultje]

Hi Luca,

On Sat, Feb 28, 2009 at 1:38 PM, Luca Abeni <lucabe72 at email.it> wrote:
> Wow... That part of code looks... Scary.
> But it might explain the funny comment in rtp_parse_mp4_au()...

Heh. :-).

>> On that line, I suppose attached patch fixes the same issue and is in
>> fact much simpler.
>
> I suspect this would break the timestamps for all the frames that are
> not the first one in an RTP packet.

The code is only executed if s->parse_packet is non-NULL, and for the
first frame in a RTP packet finalize_packet() isn't called either if
s->parse_packet is non-NULL. So either it breaks it consistently
(which would suck less), or it isn't actually necessary. I don't know
which one is true.

Ronald