[FFmpeg-devel] [RFC] rtsp.c EOF support

[Michael Niedermayer]

On Sat, Feb 28, 2009 at 08:28:28AM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Sat, Feb 28, 2009 at 8:19 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Sat, Feb 28, 2009 at 12:56:29AM -0500, Ronald S. Bultje wrote:
> >> Index: ffmpeg-svn/libavformat/file.c
> >> ===================================================================
> >> --- ffmpeg-svn.orig/libavformat/file.c ? ? ? ?2009-01-23 20:03:59.000000000 -0500
> >> +++ ffmpeg-svn/libavformat/file.c ? ? 2009-02-28 00:12:52.000000000 -0500
> >> @@ -82,6 +82,11 @@
> >> ? ? ?return close(fd);
> >> ?}
> >>
> >> +static int file_get_handle(URLContext *h)
> >> +{
> >> + ? ?return (size_t)h->priv_data;
> >> +}
> >
> > why size_t -> int ?
> > these types arent the same, which is wrong for the handle?
> 
> file.c uses size_t, but all other protocols use int. Which do you
> prefer? I'll just change either one.

the correct one
open() in POSIX/ISO C has a type and only that is correct
i think its int but didnt check, i rathet try to review a few more
patches or fix a few more serious bugs than check POSIX now.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090228/9fb59a69/attachment.pgp>