[FFmpeg-devel] [PATCH] --enable-libx264 and --enable-libxvid depend on --enable-pthread

[Robert Swain]

2009/2/27 M?ns Rullg?rd <mans at mansr.com>:
> Aurelien Jacobs <aurel at gnuage.org> writes:
>
>> Jason Garrett-Glaser wrote:
>>
>>> On Fri, Feb 27, 2009 at 12:00 PM, M?ns Rullg?rd <mans at mansr.com> wrote:
>>> > Peter Eszlari <peter.eszlari at googlemail.com> writes:
>>> >
>>> >> see $subj
>>> >>
>>> >> Index: configure
>>> >> ===================================================================
>>> >> --- configure (revision 17647)
>>> >> +++ configure (working copy)
>>> >> @@ -1687,6 +1687,16 @@
>>> >> ? ? ?die_gpl_disabled "The software scaler" ? ? swscale
>>> >> ?fi
>>> >>
>>> >> +if ! enabled pthreads; then
>>> >> + ? ?die_pthreads_disabled(){
>>> >> + ? ? ? ?name=$1
>>> >> + ? ? ? ?shift
>>> >> + ? ? ? ?enabled_any $@ && die "$name needs pthreads and --enable-pthreads is not specified."
>>> >> + ? ?}
>>> >> + ? ?die_pthreads_disabled "libx264" ? ? ? ? ? ? ? ? libx264
>>> >> + ? ?die_pthreads_disabled "libxvidcore" ? ? ? ? ? ? libxvid
>>> >> +fi
>>> >
>>> > That is not necessarily true.
>>>
>>> More correctly, if libxvid and libx264 were compiled with pthreads,
>>> they depend on pthreads.
>>
>> AFAIR, this is only a problem when libx264 is compiled statically
>> (which is the default) because static libs unfortunately don't embed
>> a list of their dependencies (unlike shared libs), and because our
>> beloved configure maintainers hate pkg-config and refuse to use it
>> to compensate static libs limitations...
>
> Using pkg-config would cause way more trouble that it might solve.

Why?

Regards,
Rob