[FFmpeg-devel] [PATCH] libavdevice: JACK demuxer

[Måns Rullgård]

Olivier Guilyardi <list at samalyse.com> writes:

> M?ns Rullg?rd wrote:
>> Olivier Guilyardi <list at samalyse.com> writes:
>> 
>>> Index: configure
>>> ===================================================================
>>> --- configure	(revision 17646)
>>> +++ configure	(working copy)
>>> @@ -1095,6 +1095,8 @@
>>>  bktr_demuxer_deps_any="dev_bktr_ioctl_bt848_h machine_ioctl_bt848_h
>>> dev_video_bktr_ioctl_bt848_h dev_ic_bt8xx_h"
>>>  dirac_demuxer_deps="dirac_parser"
>>>  dv1394_demuxer_deps="dv1394 dv_demuxer"
>>> +jack_demuxer_deps="jack_jack_h"
>>> +jack_demuxer_extralibs="-ljack -lpthread -lrt"
>>>  libdc1394_demuxer_deps="libdc1394"
>>>  libnut_demuxer_deps="libnut"
>>>  libnut_muxer_deps="libnut"
>>> @@ -2111,6 +2113,8 @@
>>>  check_header alsa/asoundlib.h &&
>>>  check_lib2 alsa/asoundlib.h snd_pcm_htimestamp -lasound
>>>
>>> +check_header jack/jack.h
>>> +
>>>  # deal with the X11 frame grabber
>>>  enabled x11grab                         &&
>>>  check_header X11/Xlib.h                 &&
>> 
>> Why don't you check_libs for -ljack?
>
> Because I'm not used to hand crafted configure scripts ;) And I usually let
> pkg-config do the dirty job.
>
> Attached is the version 0.5 of the patch, which fixes this, and a
> couple of other issues: the client member of PrivateData is now
> marked volatile, and when polling times out a bogus timeout value
> was printed.

Using volatile is almost always wrong.

> Index: configure
> ===================================================================
> --- configure	(revision 17647)
> +++ configure	(working copy)
> @@ -1095,6 +1095,8 @@
>  bktr_demuxer_deps_any="dev_bktr_ioctl_bt848_h machine_ioctl_bt848_h dev_video_bktr_ioctl_bt848_h dev_ic_bt8xx_h"
>  dirac_demuxer_deps="dirac_parser"
>  dv1394_demuxer_deps="dv1394 dv_demuxer"
> +jack_demuxer_deps="jack_jack_h"
> +jack_demuxer_extralibs="-ljack"
>  libdc1394_demuxer_deps="libdc1394"
>  libnut_demuxer_deps="libnut"
>  libnut_muxer_deps="libnut"
> @@ -2111,6 +2113,9 @@
>  check_header alsa/asoundlib.h &&
>  check_lib2 alsa/asoundlib.h snd_pcm_htimestamp -lasound
>  
> +check_header jack/jack.h && 
> +check_lib2 jack/jack.h jack_client_open -ljack
> +
>  # deal with the X11 frame grabber
>  enabled x11grab                         &&
>  check_header X11/Xlib.h                 &&

check_lib[2] already does check_headers, so no need to do it again; I
fixed the alsa check just now.

-- 
M?ns Rullg?rd
mans at mansr.com