[FFmpeg-devel] [PATCH][VAAPI][1/6] Add VA API formats (take 2)

[Michael Niedermayer]

On Thu, Feb 26, 2009 at 02:58:31PM +0100, Gwenole Beauchesne wrote:
> On Thu, 26 Feb 2009, Michael Niedermayer wrote:
>
>> The problem is that a version of lavc after this patch claims to support
>> PIX_FMT_VAAPI_VLD for real video msmpeg4, mpeg4, h263 ...
>> but it does not support any of it (yet)
>> if this version of lavc is linked against a mplayer of lets say 3 month
>> later that already does have VAAPI-mpeg4 support then its get_format() 
>> will
>> select PIX_FMT_VAAPI_VLD and things would fall apart ...
>
> Finally added a local pixfmt_list_420[] on a per-codec basis. New patch 
> attached that only lists new PIX_FMTs. The same, manually edited actually. 
> ;-)

> commit 959284b434261af93162b384e27b986779a8e580
> Author: Gwenole Beauchesne <gbeauchesne at splitted-desktop.com>
> Date:   Wed Feb 25 15:05:52 2009 +0000
> 
>     Add VA API pixel formats.
> 
> diff --git a/libavcodec/imgconvert.c b/libavcodec/imgconvert.c
> index 84e1bee..9f5db68 100644
> --- a/libavcodec/imgconvert.c
> +++ b/libavcodec/imgconvert.c
> @@ -419,6 +419,20 @@ static const PixFmtInfo pix_fmt_info[PIX_FMT_NB] = {
>          .depth = 8,
>          .x_chroma_shift = 0, .y_chroma_shift = 0,
>      },
> +
> +    /* VA API formats */
> +    [PIX_FMT_VAAPI_MOCO] = {
> +        .name = "vaapi_moco",
> +        .is_hwaccel = 1,
> +    },
> +    [PIX_FMT_VAAPI_IDCT] = {
> +        .name = "vaapi_idct",
> +        .is_hwaccel = 1,
> +    },
> +    [PIX_FMT_VAAPI_VLD] = {
> +        .name = "vaapi_vld",
> +        .is_hwaccel = 1,
> +    },
>  };

these are missing the chroma sub sample values

[off topic] also ff_print_debug_info() might be missing a if hw_accel return

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090227/bad99022/attachment.pgp>