[FFmpeg-devel] [PATCH] Integrate avfiltergraph.[ch] and graphparser.[ch]

Måns Rullgård mans
Fri Feb 27 11:24:20 CET 2009


Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:

> On date Friday 2009-02-27 01:58:40 +0100, Michael Niedermayer encoded:
>> On Fri, Feb 27, 2009 at 01:34:37AM +0100, Stefano Sabatini wrote:
>> > On date Friday 2009-02-27 01:05:21 +0100, Michael Niedermayer encoded:
>> > > On Thu, Feb 26, 2009 at 11:18:41PM +0100, Stefano Sabatini wrote:
> [...]
>> > > > Agree, please check it again, alternatively we could simply not to
>> > > > export the API for the moment, but simply include it in the lib
>> > > > object.
>> > > 
>> > > ok if the headers are needed by ffmpeg/ffplay
>> > 
>> > Do you mean *after* lavfi integration? Yes both of them parse a graph
>> > description and so they need graphparser.h (which includes
>> > avfiltergraph.h).
>> 
>> i meant it can be commited if it will be needed.
>> 
>> but if for example we redesign things so that they wont be needed then
>> you may not commit :)
>
> Well, since I still have not read permission in /dev/future, I
> posticipate the patch application when we'll be next to integrate
> ffplay/ffmpeg (but I can't see how we can do that without
> avfiltergraph/graphparser).
>
> My plan is now:
> * commit vf_scale.c
> * commit vf_format.c
> * integrate ffplay
> * integrate ffmpeg
>
> I don't know if a simple review+commit is sufficient, or if I should
> import somehow the history of the corresponding files to FFmpeg.

The history is available in the gsoc repo for anyone who cares.  No
need to spam the ffmpeg repo with more or less fake history that might
not even compile.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list