[FFmpeg-devel] [PATCH][VAAPI][2/6] Add common data structures and helpers

Gwenole Beauchesne gbeauchesne
Fri Feb 27 10:58:31 CET 2009


Hi,

On Fri, 27 Feb 2009, Benoit Fouet wrote:

>> +    r = s->avctx->get_buffer(s->avctx, (AVFrame*)pic);
>> +
>> +    if (r<0 || !pic->age || !pic->type || !pic->data[0]) {
>> +        av_log(s->avctx, AV_LOG_ERROR, "get_buffer() failed (%d %d %d
>> %p)\n", r, pic->age, pic->type, pic->data[0]);
>>
>
> isn't this leaking memory (at least the hwaccel_data) ?

Indeed, in this error condition. Fixed, thanks. Though, it didn't leak in 
the common (correct) case, according to my valgrind traces.




More information about the ffmpeg-devel mailing list