[FFmpeg-devel] [PATCH] add context to av_log() calls

[Benoit Fouet]

On 02/27/2009 09:24 AM, M?ns Rullg?rd wrote:
> Benoit Fouet <benoit.fouet at free.fr> writes:
>
>   
>> On 02/27/2009 09:16 AM, Baptiste Coudurier wrote:
>>     
>>> Hi Benoit,
>>>
>>> On 2/27/2009 12:06 AM, Benoit Fouet wrote:
>>>       
>>>> On 02/16/2009 02:35 PM, Benoit Fouet wrote:
>>>>         
>>>>> Hi,
>>>>>
>>>>> here are some patches to $subj in libavformat
>>>>> (note: I had to add the context for avi and ape as a parameter to a
>>>>> function)
>>>>>
>>>>>           
>>>> some of the patches lack reviews:
>>>>     libavformat/mov.c      : Michael or Baptiste ?
>>>>     libavformat/txd.c      : Ivo ?
>>>>     libavformat/rtp_h264.c : Luca ?
>>>>
>>>> they are rather trivial, but you never know :)
>>>>         
>>> I don't see a mov.c diff, am I blind or did I loose a mail ?
>>>
>>>       
>> or did I send the diffs ? :)
>> here they are, sorry:
>>
>> Index: libavformat/mov.c
>> ===================================================================
>> --- libavformat/mov.c (revision 17632)
>> +++ libavformat/mov.c (working copy)
>> @@ -1732,7 +1732,7 @@ static int mov_read_cmov(MOVContext *c,
>> if (get_le32(pb) != MKTAG('d','c','o','m'))
>> return -1;
>> if (get_le32(pb) != MKTAG('z','l','i','b')) {
>> - av_log(NULL, AV_LOG_ERROR, "unknown compression for cmov atom !");
>> + av_log(c->fc, AV_LOG_ERROR, "unknown compression for cmov atom !");
>> return -1;
>> }
>> get_be32(pb); /* cmvd atom */
>>     
>
> That diff looks mangled.
>
>   

I'm very impressed you saw that...

Ben