[FFmpeg-devel] [PATCH] Integrate avfiltergraph.[ch] and graphparser.[ch]

[Michael Niedermayer]

On Fri, Feb 27, 2009 at 01:34:37AM +0100, Stefano Sabatini wrote:
> On date Friday 2009-02-27 01:05:21 +0100, Michael Niedermayer encoded:
> > On Thu, Feb 26, 2009 at 11:18:41PM +0100, Stefano Sabatini wrote:
> > > On date Thursday 2009-02-26 22:39:29 +0100, Michael Niedermayer encoded:
> > > > On Thu, Feb 26, 2009 at 09:16:42PM +0100, Stefano Sabatini wrote:
> > > > > Hi all,
> > > > > 
> > > > > avfiltergraph and graphparser are not still exported to the public
> > > > > though they are in SVN, I realized this too late since I upgraded
> > > > > minor more than once.
> > > > > 
> > > > > Now reviewing the headers I found that the names are all nice and
> > > > > consistent, but two for which I propose the renames:
> > > > > 
> > > > 
> > > > 
> > > > > avfilter_destroy_graph -> avfilter_graph_destroy
> > > > > and
> > > > > avfilter_parse_graph   -> avfilter_graph_parse
> > > > 
> > > > ok
> > > 
> > > Applied.
> > >  
> > > > > The functions are not still public, so no need to update versions,
> > > > > afterwards I propose to apply the attached patches.
> > > > 
> > > > like has been said a big fat warning is needed first
> > > 
> > > Agree, please check it again, alternatively we could simply not to
> > > export the API for the moment, but simply include it in the lib
> > > object.
> > 
> > ok if the headers are needed by ffmpeg/ffplay
> 
> Do you mean *after* lavfi integration? Yes both of them parse a graph
> description and so they need graphparser.h (which includes
> avfiltergraph.h).

i meant it can be commited if it will be needed.

but if for example we redesign things so that they wont be needed then
you may not commit :)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090227/e23454fa/attachment.pgp>