[FFmpeg-devel] [RFC][PATCH] ticks_per_frame / timebase

[Michael Niedermayer]

On Thu, Feb 26, 2009 at 02:18:41PM -0800, Baptiste Coudurier wrote:
> Hi guys,
> 
> Michael Niedermayer wrote:
> > On Thu, Feb 26, 2009 at 10:05:28PM +0100, Ivan Schreter wrote:
> >> Michael Niedermayer wrote:
> >>> [...]
> >>> also i think the reset of the sei vars should be in
> >>> decode_nal_units()
> >>> ...
> >>>     if(!(s->flags2 & CODEC_FLAG2_CHUNKS)){
> >>>         h->current_slice = 0;
> >>>         if (!s->first_field)
> >>>             s->current_picture_ptr= NULL;
> >>>         <-----------------------here
> >>>     }
> >>>
> >>> the reason is that just reseting at the end of a pic is "risky" if that 
> >>> end
> >>> isnt reached
> >>>
> >>>   
> >> Like in the attached patch?
> > 
> > yes, patch ok
> > 
> > btw, if you want a svn write account, (and agree to the devel/svn policy
> > and split patches a little more, this one should be
> > factorizing the code and then seperately adding the new call)
> > then send diego b. some username & password gpg encrypted
> > 
> 
> Applied both patches:
> 
> ffmpeg -i h264.mp4 -vcodec copy test.mov
> 
> Seems stream 1 codec frame rate differs from container frame rate: 12.50
> (25/2) -> 25.00 (25/1)
> Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 'H264.mp4':
>   Duration: 00:00:02.18, start: 0.000000, bitrate: 2245 kb/s
>     Stream #0.0(eng): Audio: aac, 44100 Hz, stereo, s16
>     Stream #0.1(eng): Video: h264, yuv420p, 720x576, 25 tbr, 25 tbn, 25 tbc
> File 'test.mov' already exists. Overwrite ? [y/N] y
> Output #0, mov, to 'test.mov':
>     Stream #0.0(eng): Video: libx264, yuv420p, 720x576, q=2-31, 90k tbn,
> 25 tbc
>     Stream #0.1(eng): Audio: libfaac, 44100 Hz, stereo, s16, 64 kb/s
> 
> Is this supposed to report 12.50 ?

no, ive droped the hunk that messed with the printing in ffmpeg.c locally
is the nonsense it prints the only problem? or are there other problems?


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you really think that XML is the answer, then you definitly missunderstood
the question -- Attila Kinali
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090226/afc15eee/attachment.pgp>