[FFmpeg-devel] [PATCH] fixes and optimization for ff_find_start_code ()

[Matthias Dahl]

On Thursday 26 February 2009 17:03:49 you wrote:

> this mixes cosmetic and functional changes and thus is unreviewable

Sorry, the attached patch is strictly functional changes.

> > +    *state = 0xFFFFFFFF;
>
> this though looks very wrong

Currently ff_find_start_code() puts garbage in state when no start code could 
be found. That garbage can be anything. This way the caller has a way to 
actually know if a valid start code was found or not. I reviewed all users of 
this function and there will be no problem with this. We can even remove code 
here and here which tries to deal with exactly that problem. Or is there 
something I am not seeing?

Best regards,
matthias.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-and-optimize-ff_find_start_code_v2.diff
Type: text/x-patch
Size: 2759 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090226/31c5fc52/attachment.bin>