[FFmpeg-devel] [PATCH] h264.c: add HW acceleration hooks

[Michael Niedermayer]

On Thu, Feb 26, 2009 at 01:11:28PM +0100, Gwenole Beauchesne wrote:
> On Thu, 26 Feb 2009, Michael Niedermayer wrote:
> 
> >>>> Generally, actually all cases, AVHWAccel::end_frame() is sending the
> >>>> control blocks to the accelerator, and does the actual decoding. We
> >>>> could ignore errors as the original VDPAU code though.
> >>>
> >>> iam not asking to ignore them but rather asking what exactly
> >>> the return -1 at that point is supposed to achive?
> >>
> >> You are right, it's probably just more useful to return the usual
> >> get_consumed_bytes(). OK to replace the return -1; with an
> >> av_log(ERROR,..)?
> >>
> >> On the other hand, decode_frame() usually returns -1 on errors and let the
> >> callee manage whatever it wants.
> >
> > yes but you are returning it from the middle, this has to be reviewed for
> > memleaks and such stuff and tested
> > i suspect you didnt test it ...
> 
> I indeed did not test the error path. Now, I have (Grey.ts):

good and is the output vissually similar in quality depending on
return -1 vs. not (there may be some messed up references or such)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090226/f2af6021/attachment.pgp>