[FFmpeg-devel] [PATCH][VAAPI][1/6] Add VA API formats

Michael Niedermayer michaelni
Thu Feb 26 12:49:41 CET 2009

On Thu, Feb 26, 2009 at 12:46:27PM +0100, Gwenole Beauchesne wrote:
> On Thu, 26 Feb 2009, Michael Niedermayer wrote:
> >> @@ -76,6 +76,7 @@ const uint8_t ff_mpeg1_dc_scale_table[128]={
> >>  };
> >>
> >>  const enum PixelFormat ff_pixfmt_list_420[] = {
> >> +    PIX_FMT_VAAPI_VLD,
> >>      PIX_FMT_YUV420P,
> >>      PIX_FMT_NONE
> >>  };
> >
> > considering that this list is used by some codecs that VAAPI does not support
> > this isnt correct
> Sure some codecs are not supported, but I thought this was your intent 
> because ::get_format() has to check for it anyway. i.e. the API can 
> specify support for a codec but the user has to check the HW actually 
> supports it. So, even if we add the HW formats on per-codec, there are 
> cases were it wouldn't be supported for real. e.g. VDPAU VC-1 in the past.

The problem is that a version of lavc after this patch claims to support
PIX_FMT_VAAPI_VLD for real video msmpeg4, mpeg4, h263 ...
but it does not support any of it (yet)
if this version of lavc is linked against a mplayer of lets say 3 month
later that already does have VAAPI-mpeg4 support then its get_format() will
select PIX_FMT_VAAPI_VLD and things would fall apart ...


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090226/dbcecd68/attachment.pgp>

More information about the ffmpeg-devel mailing list