[FFmpeg-devel] [RFC] [PATCH] casts warnings

[Baptiste Coudurier]

Hi Aurel,

Aurelien Jacobs wrote:
> Baptiste Coudurier wrote:
> 
>> Baptiste Coudurier wrote:
>>> Hi,
>>>
>>> I believe it is better to not cast in the following situations, to let
>>> gcc issue the real warning about assignment. What do you think ?
> 
> I agree. Those are real warnings ! We shouldn't hide them.
> And ideally, we should fix them properly.
> 
>>> Besides we might think of changing bsf api when outputing original
>>> buffer, we might not do it, and specify in documentation, that this
>>> means bitstream is already formated.
>>> User can then do what he wants in this case. Any opinion ?
> 
> That could be a good way to solve those warnings.
> The other obvious and ugly solution would be to allocate and copy in
> the output buffer, even when the bitstream is already formated and
> don't need to be changed. But if we can avoid resorting to such an
> extra useless copy, that would be better.

Yes, we could. Any other opinion ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org