[FFmpeg-devel] [PATCH]Fix MPlayer segfault

Michael Niedermayer michaelni
Wed Feb 25 17:23:28 CET 2009

On Wed, Feb 25, 2009 at 05:00:47PM +0100, Gwenole Beauchesne wrote:
> On Wed, 25 Feb 2009, Carl Eugen Hoyos wrote:
> > MPlayer currently crashes if one tries playback of VC1 or WMV3.
> > Attached patch fixes the segfault.
> The reason is vc1_decode_init() is calling the h263dec.c init function and 
> that one depends on valid ->pix_fmts. Shouldn't the default ::get_format() 
> check for NULL fmt[] and return PIX_FMT_NONE in that case? That'd be the 
> better fix, isn't it?

no, get_format(NULL) is invalid nonsense
if the direction is correct then get_format() shouldnt be called in the first
place, anyway, i have no time now, ill look into this in 2h if noone else did

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090225/4a0c9f15/attachment.pgp>

More information about the ffmpeg-devel mailing list