[FFmpeg-devel] [PATCH] HWAccel infrastructure (take 7.1)

[Gwenole Beauchesne]

Le 24 f?vr. 09 ? 19:01, Reimar D?ffinger a ?crit :

>> changing pix_fmt in the middle of a file is not impossible ...
>
> It is a bit problematic conceptually though, and does it actually work
> or would most libavc users probably handle it in a highly exploitable
> way?

This generally implies to destroy the current decode pipeline  
(context). For some other APIs, that could be troublesome because this  
also implies trashing older reference frames and all previous data.  
But does it really matter? I mean, if profile changes in the  
bitstream, that also means we no longer care of previous state, right?

>>> Not using per-codec PIX_FMTs seems more likely to me to just  
>>> complicate
>>> things, though I do not know for sure.
>>
>> well i have no strong oppinion on this but i dislike the
>> half page of code per API X codec X variant (IDCT/MC/VLC)
>
> I just wanted to express my suspicion that this, contrary to the other
> case, might just move that half page of code to whoever uses lavc :-)
> If there wasn't the issue of public API it's the typical case where  
> I'd
> suggest to get it in one way and then see if it can and should be
> changed.

Yes, the user has to check the codec itself + some extra things. But  
hey, now that this is done in take 7.3, reverting the code once more  
would be terribly embarassing.