[FFmpeg-devel] [PATCH] HWAccel infrastructure (take 7.1)

[Gwenole Beauchesne]

On Tue, 24 Feb 2009, Michael Niedermayer wrote:

>> What excuse would you find next? Were you on drugs when you accepted the
>> earlier patches?
>
> VDPAU did not add multiple near identical lists for get_format(), the problem
> didnt exist before so required no solution before ...

The question was referring to the new decision to get rid of 
PIX_FMT_HWACCEL_CODEC. This is independant from the current patchsets and 
the problem did exist before.

>> Please clearly tell why does it
>> take so much time to accept so much simpler patches than the initial VDPAU
>> work? There must be a reason, but I don't get it. Ah, probably too narrow
>> lookahead buffer, but that would also be surprising.
>
> its because you are spending more time making attempts at insulting me instead
> of coding.

Not at all, but sorry if porting (VDPAU, VAAPI) and especially regtesting 
among all codecs (MPEG-2, MPEG-4, H.263, H.264, WMV3, VC-1) does not take 
zero time.

>> Then you also nicely break Reimar's recent map tables work since you no
>> longer have any bijection there. And requiring an extra arg (for e.g.
>> codec_id) is not a really clean approach either.
>
> comments from reimar as well as comments from you about improving the design
> and implementation are welcome

The only objection I have is to name something a2b and using a "c" to 
achieve the operation. Otherwise, it works and actually helps implementing 
surface bits readback.