[FFmpeg-devel] [PATCH] HWAccel infrastructure (take 7.1)

[Gwenole Beauchesne]

On Tue, 24 Feb 2009, Michael Niedermayer wrote:

> On Tue, Feb 24, 2009 at 03:56:55PM +0100, Gwenole Beauchesne wrote:
>> On Tue, 24 Feb 2009, Michael Niedermayer wrote:
>>
>>>>> Now, your suggested approach requires as many lists as (HW accelerators) x
>>>>> (chroma formats) x (sub-codecs).
>>>>
>>>> You dont need to split pix_fmts per codec, its done currently and iam not
>>>> asking you to change it but i would be happy if you did change it :)
>>>
>>> after seeing your patch, i think per codec pix_fmts really should be
>>> removed.
>>> This would make the code much simpler and cleaner. It also would greatly
>>> simplify get_format() for user apps,having to test just for one pix_fmt
>>> er hwaccel API instead of for one per codec X API
>>
>> Not really. The user app then would have to check avctx->codec->id itself
>> as not all accelerators would implement the same codec...
>
> and not all accelerators implement all profiles, we already insistent on
> removing profiles from the pix_fmts, i dont see why codecs should be
> handled differently.

And how would you look up the HWAccel then if you no longer have the codec 
info in the pix_fmt name? And why not do the "reference" implementation 
for VDPAU vs. AVHWAccel yourself? You will probably spot the reasons in 
that case.