[FFmpeg-devel] [PATCH] HWAccel infrastructure (take 7.1)

Michael Niedermayer michaelni
Tue Feb 24 16:10:16 CET 2009


On Tue, Feb 24, 2009 at 03:56:55PM +0100, Gwenole Beauchesne wrote:
> On Tue, 24 Feb 2009, Michael Niedermayer wrote:
> 
> >>> Now, your suggested approach requires as many lists as (HW accelerators) x
> >>> (chroma formats) x (sub-codecs).
> >>
> >> You dont need to split pix_fmts per codec, its done currently and iam not
> >> asking you to change it but i would be happy if you did change it :)
> >
> > after seeing your patch, i think per codec pix_fmts really should be
> > removed.
> > This would make the code much simpler and cleaner. It also would greatly
> > simplify get_format() for user apps,having to test just for one pix_fmt
> > er hwaccel API instead of for one per codec X API
> 
> Not really. The user app then would have to check avctx->codec->id itself 
> as not all accelerators would implement the same codec...

and not all accelerators implement all profiles, we already insistent on
removing profiles from the pix_fmts, i dont see why codecs should be
handled differently.
the user app can use whatever it needs from AVCodecContext to decide if
its accelerator can handle it or not ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090224/5ec3cdb9/attachment.pgp>



More information about the ffmpeg-devel mailing list