[FFmpeg-devel] [PATCH] Add ff_h263_find_resync_marker() function

[Michael Niedermayer]

On Mon, Feb 23, 2009 at 07:47:49PM +0100, Gwenole Beauchesne wrote:
> Le 23 f?vr. 09 ? 19:15, Michael Niedermayer a ?crit :
> 
> > On Mon, Feb 23, 2009 at 04:08:03PM +0100, Gwenole Beauchesne wrote:
> >> Hi,
> >>
> >> This patch adds ff_h263_find_resync_marker() to find the bit  
> >> position of
> >> the next resync_marker, if any. This is only useful to simplify  
> >> MPEG-4
> >> HWAccel patch. Besides, it's also the correct fix because  
> >> ff_h263_resync()
> >> will alter the current slice info (s->qscale for instance) whereas  
> >> we have
> >> not called AVHWAccel::decode_slice() yet.
> >
> > cant
> > s->current_picture.qscale_table
> > be used to easily get the previous qscale?
> 
> Well, qscale was only an example and other members are altered...  
> Actually, ff_h263_resync() is doing three things at once.
> 
> > either way duplicating the resync code is not ok
> 
> I had hoped you'd have an idea how to factorize it. ;-)

The first thing i see is that ff_h263_resync() is not designed
to skip slices, its not fast at that, rather its designed to skip a few
bytes after a slice has been decoded.

so factorization vs. copy and paste is not the only question here.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090223/c0e9b0fa/attachment.pgp>