[FFmpeg-devel] [PATCH] fix in ff_celp_lp_synthesis_filterf

Robert Swain robert.swain
Mon Feb 23 21:25:39 CET 2009

2009/2/23 Vitor Sessak <vitor1001 at gmail.com>:
> Kenan Gillet wrote:
>> i have noticed while working on the AMR SoC that the
>> ff_celp_lp_synthesis_filterf
>> apply backwardly the filter adding instead of subtracting the filtered
>> signal.
>> The patches has been tested for the QCELP decoder, which is so far the
>> only
>> code using this function,  and it gives same bit ouput.
> I like this patch, it allows also a nice simplification of ra288.c
> (attached). Who is supposed to review the original patch? Michael, Reynaldo
> or both?

I don't know, but for what it's worth, the simplification it enables
to AMR looks good to me.


More information about the ffmpeg-devel mailing list