[FFmpeg-devel] [PATCH] HWAccel infrastructure (take 7)

[Gwenole Beauchesne]

Hi,

On Fri, 20 Feb 2009, Michael Niedermayer wrote:

>> +    avctx->hwaccel = ff_query_hwaccel_codec(avctx, avctx->codec->id);
>> +    if (avctx->hwaccel)
>> +        avctx->pix_fmt = avctx->hwaccel->pix_fmt;
>> +    else
>> +        avctx->pix_fmt = PIX_FMT_YUV420P;
>> +
>>      /* select sub codec */
>>      switch(avctx->codec->id) {
>>      case CODEC_ID_H263:
>
> avctx->pix_fmt = ff_query_pixfmt(avctx, avctx->codec->id);
> avctx->hwaccel = ff_pixfmt_to_hwaccal(avctx->codec->id, avctx->pix_fmt);

Finally, it looks a little messier that way, IMHO. Just have a look, 
particularly in mpeg12.c. I have attached a new patch and SVN updated but 
haven't found any hunk committed in. So, the attached patch is still the 
whole thing.

I think we should keep the initial semantics for ff_query_hwaccel_pixfmt() 
(i.e. passing hwaccel pixfmts only) and then possibly migrate everything 
for all sw formats too.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg.hwaccel.7.patch
Type: text/x-diff
Size: 31555 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090223/b229885d/attachment.patch>