[FFmpeg-devel] Remove force of largefile defines in common.mak

[Diego Biurrun]

On Thu, Feb 19, 2009 at 03:31:53PM +0100, Hans-Christian Egtvedt wrote:
> 
> I've had a quick discussion of this on mplayer-dev-eng, but they sync
> their common.mak with common.mak from FFmpeg.
> 
> The problem I encounter is that CFLAGS is forced to contain
> _FILE_OFFSET_BITS=64 and _LARGEFILE_SOURCE.
> 
> common.mak:21
> CFLAGS := -DHAVE_AV_CONFIG_H -D_FILE_OFFSET_BITS=64 D_LARGEFILE_SOURCE \
>           -I$(BUILD_ROOT_REL) -I$(SRC_PATH) $(OPTFLAGS)
> 
> On uClibc it results in an #error if the user specifies
> _FILE_OFFSET_BITS=64 and largefile support is not enabled.
> 
> Could these defines be removed from common.nak?
> 
> Or could largefile support be detected by configure, or a switch to the
> configure script?

Please test the attached patch which should fix your problem by
implementing the flag detection in configure.

Diego
-------------- next part --------------
A non-text attachment was scrubbed...
Name: largefile.diff
Type: text/x-diff
Size: 933 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090223/5faa0c94/attachment.diff>