[FFmpeg-devel] [PATCH] document rtsp.h

[Michael Niedermayer]

On Sat, Feb 21, 2009 at 05:29:11PM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Sat, Feb 21, 2009 at 9:36 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Sat, Feb 21, 2009 at 09:02:03AM -0500, Ronald S. Bultje wrote:
> >> 2009/2/16 Michael Niedermayer <michaelni at gmx.at>:
> >> > On Mon, Feb 16, 2009 at 11:32:45AM -0500, Ronald S. Bultje wrote:
> >> >> >> +    /** the seek value requested when calling av_seek_frame(). This way,
> >> >> >> +     * the seek value is saved if we are currently paused and will be
> >> >> >> +     * transmitted at the next PLAY RTSP command. See rtsp_read_play(). */
> >> >> >>      int64_t seek_timestamp;
> >> >> >
> >> >> > do you realize that this is broken ?
> >> >> >
> >> >> > pause, seek to 1s from start, play 5h, pause, play
> >> >> >
> >> >> > the last play will seek back to 1s
> >> >> > no? then the comment is wrong ...
> >> >>
> >> >> It's only used once of course (practically, the code is kind of funny
> >> >> but I think it's correct). It's cached in case we're paused while
> >> >> seeking.
> >> >
> >> > as i said, what the comment explains is _TOTALLY_ broken
> >> > so if you say the code is not then the comment is
> >>
> >> How about this?
> >
> > good enough for me
> 
> OK, attached is an updated patch against trunk, should address all
> issues except the fact that not all payloads are implemented as a
> RTPDynamicPayloadHandler. hopefully Luca will reply in this thread
> also.

[...]
> +    /** data/packet transport protocol; e.g. RTP or RDT */
>      enum RTSPTransport transport;
> +    /** network layer transport protocol; e.g. TCP or UDP uni-/multicast */
>      enum RTSPLowerTransport lower_transport;
>  } RTSPTransportField;
>  
> +/**
> + * This describes the server response to each RTSP command.
> + */
>  typedef struct RTSPMessageHeader {
> +    /** length of the data following this header */
>      int content_length;

> -    enum RTSPStatusCode status_code; /**< response code from server */
> +    /**< response code from server */
> +    enum RTSPStatusCode status_code;

hmpf ...
unrelated change
besides this change is wrong

also i would prefer to see a empty line before every doxy comment

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090222/388a4b65/attachment.pgp>