[FFmpeg-devel] [PATCH] fix raw FLAC muxer extradata handling

[Aurelien Jacobs]

On Sat, 21 Feb 2009 21:25:45 -0500
Justin Ruggles <justin.ruggles at gmail.com> wrote:

> Michael Niedermayer wrote:
> > On Sat, Feb 21, 2009 at 04:27:54PM -0500, Justin Ruggles wrote:
> > [...]
> >> --- a/libavformat/raw.c
> >> +++ b/libavformat/raw.c
> >> @@ -31,12 +31,11 @@
> >>  
> >>  /* simple formats */
> >>  #if CONFIG_FLAC_MUXER
> >> -static int flac_write_header(struct AVFormatContext *s)
> >> +int ff_flac_write_header(ByteIOContext *pb, AVCodecContext *codec)
> >>  {
> > 
> > i doubt a little that this belongs on raw.c/h
> 
> True, it would definitely make dependencies simpler if it were split it
> into a separate file.  How about libavformat/flac.[ch]?

Sounds good. Or you may also consider moving the whole flac muxer into
a flacenc.c file.

Aurel