[FFmpeg-devel] [PATCH] Swscale YUV2RGB table generator

Kostya kostya.shishkov
Sun Feb 22 13:38:22 CET 2009


On Sun, Feb 22, 2009 at 12:12:57PM +0100, Diego Biurrun wrote:
> On Sun, Feb 22, 2009 at 01:53:09PM +0200, Kostya wrote:
> > On Sun, Feb 22, 2009 at 11:50:50AM +0100, Diego Biurrun wrote:
> > > On Sun, Feb 22, 2009 at 12:20:16PM +0200, Kostya wrote:
> > > > On Thu, Feb 12, 2009 at 11:40:59PM +0100, Michael Niedermayer wrote:
> > > > > On Thu, Feb 12, 2009 at 10:26:21AM +0200, Kostya wrote:
> > > > [...]
> > > > > > > maybe a few const could be added?
> > > > > > > 
> > > > > > > ok except these
> > > > > > 
> > > > > > Since it's not wholly identical with the old one, regressions are changed too.
> > > > > > Attached an example of mine obtained at PPC.
> > > > > 
> > > > > the regression change looks harmless after a quick look ...
> > > > 
> > > > I took the liberty to apply it after all.
> > > 
> > > yuv2rgb.c is not compiled but still around.  IMO you should just have
> > > replaced one file with the other and not add a new one with a 2 suffix.
> > 
> > I could do that but I'm unsure of consequences to SVN history - this is a new
> > implementation, not some patch to the old file after all.
> 
> I would delete the old one and rename the new one to the old name.
> 
> If you prefer to keep the new name, there is still no need to keep the
> old file around, it is now unused.

Feel free to drop it then along with enabling swscale in LGPL.
 
> Diego




More information about the ffmpeg-devel mailing list