[FFmpeg-devel] [PATCH] Workaround Mac-OS x86_64 dynamic loader bug for Yasm generated code

[Diego Biurrun]

On Sun, Feb 22, 2009 at 01:04:35AM +0000, Loren Merritt wrote:
> On Sat, 14 Feb 2009, Art Clarke wrote:
> 
> > On Wed, Feb 4, 2009 at 12:53 PM, Art Clarke <aclarke at xuggle.com> wrote:
> >> On Wed, Feb 4, 2009 at 12:27 PM, Art Clarke <aclarke at xuggle.com> wrote:
> >>> See this chain for details on the problem:
> >>> http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2009-February/061189.html
> >>>
> >>> Tested on Mac and Linux in 32 and 64 bit builds and everything seems to work.
> >
> > --- libavcodec/x86/fft_mmx.asm	(revision 16989)
> > +++ libavcodec/x86/fft_mmx.asm	(working copy)
> > @@ -446,8 +446,16 @@
> > %endrep
> > %undef n
> >
> > +%ifidn __OUTPUT_FORMAT__,macho64
> > +; Putting this section in .text on x86_64 darwin causes problems
> > +section .rodata align=16
> > +%endif
> > align 8
> > dispatch_tab%3%2: pointer list_of_fft
> > +%ifidn __OUTPUT_FORMAT__,macho64
> > +; Set section back to .text
> > +section .text align=16
> > +%endif
> 
> I'm confused. Wasn't this patch already applied in r17197, 28 hours before 
> Art's ping?

No, that was a different thing, see what I attached.

Diego
-------------- next part --------------
A non-text attachment was scrubbed...
Name: r17197.diff
Type: text/x-diff
Size: 512 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090222/dabe6436/attachment.diff>