[FFmpeg-devel] Netgem

[Michael Niedermayer]

On Sat, Feb 21, 2009 at 09:36:44PM +0100, Luca Barbato wrote:
> Ronald S. Bultje wrote:
> > - h263, amr-w/nb payloads
> > - asf payload (not the same as my patchset, they apparently wrote this
> > themselves)
> > - eos notice support (interesting, we should get this in)
> > - support for RTSP messages in interleaved TCP streams or while
> > playing UDP (I've been wanting to add this for a long time, I'll try
> > to integrate this after the release)
> > - keep-alive support (also something I've been wanting to work on,
> > also after release?)
> > 
> 
> Sounds like there is a lot of useful stuff.

just sounds ...
i just went over avidec.c not a single change was useable as is.
but i commited what i thought should fix the (real) issues the hunks
pointed at, of course i couldnt test as i dont have netgems samples ...

a simple example from utils.c
+ read_packet: /* Netgem */
     if(s->read_packet)
         len = s->read_packet(s->opaque, dst, len);
     else
         len = 0;
+    if (len == AVERROR(EAGAIN)) /* Netgem */
+        goto read_packet; /* Netgem */

reexecuting len=read_packet(len) when len was EAGAIN, ya know the len this
will try to read now  ....

that said, the patch should of course be looked over, split, reviewed and
what is good merged and what is not so good rewritten first and what is
bad sent to /dev/null.
just be carefull when you take something from this patch it is clear alot of
code in there has never been tested or just works by luck, like the eof checks
at the wrong spot in avidec.c


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090221/0a56e82e/attachment.pgp>