[FFmpeg-devel] [PATCH] swscale alpha channel support

Michael Niedermayer michaelni
Sat Feb 21 21:07:40 CET 2009


On Sat, Feb 21, 2009 at 08:53:53PM +0100, C?dric Schieli wrote:
> 2009/2/21 Jason Tackaberry <tack at urandom.ca>
> 
> > On Sat, 2009-02-21 at 12:49 +0100, C?dric Schieli wrote:
> > > Attached is another patch which factorizes some code in
> > yuv2rgb_template.c
> > > to ease further yuva2rgb patch.
> >
> > Rather than reading the patch I'll be lazy and just ask: with this patch
> > applied, will yuv to rgb32 now set the alpha channel to 0xff instead of
> > 0x00?
> 
> 
> No, the aim of the patch is to use an existing alpha channel (from
> YUVA420P).
> But I agree that setting 0xff when "creating" an alpha channel would be more
> useful than setting 0x00 as for now. I've already made a patch that does
> just this (for mmx unscaled yuv420p->rgb32 and unscaled rgb24->rgb32).
> I can send it for review if changing such a "default" behaviour is ok.

you can

PS: small note, iam not sure if you are aware of it but kostya has rewritten
yuv2rgb.c and thus the one in svn will be replaced by it, iam mentioning it
so you dont waste time with it

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090221/3b7daa7a/attachment.pgp>



More information about the ffmpeg-devel mailing list