[FFmpeg-devel] [PATCH] document rtsp.h

[Michael Niedermayer]

On Sat, Feb 21, 2009 at 09:02:03AM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> 2009/2/16 Michael Niedermayer <michaelni at gmx.at>:
> > On Mon, Feb 16, 2009 at 11:32:45AM -0500, Ronald S. Bultje wrote:
> >> >> +    /** the seek value requested when calling av_seek_frame(). This way,
> >> >> +     * the seek value is saved if we are currently paused and will be
> >> >> +     * transmitted at the next PLAY RTSP command. See rtsp_read_play(). */
> >> >>      int64_t seek_timestamp;
> >> >
> >> > do you realize that this is broken ?
> >> >
> >> > pause, seek to 1s from start, play 5h, pause, play
> >> >
> >> > the last play will seek back to 1s
> >> > no? then the comment is wrong ...
> >>
> >> It's only used once of course (practically, the code is kind of funny
> >> but I think it's correct). It's cached in case we're paused while
> >> seeking.
> >
> > as i said, what the comment explains is _TOTALLY_ broken
> > so if you say the code is not then the comment is
> 
> How about this?

good enough for me


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090221/850fe16c/attachment.pgp>